Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sapi/cli: Print non-default INI settings for --ini=diff #17762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sapi/cli: Print non-default INI settings for --ini=diff #17762

wants to merge 1 commit into from
+19 −5

Conversation

TimWolla
Copy link
Member

This is a follow-up for #17459, updating the command-line flag to not modify the behavior of --ini.

see https://externals.io/message/126303

@TimWolla
sapi/cli: Print non-default INI settings for --ini=diff
6fab3bb 
This is a follow-up for php#17459, updating the command-line flag to
not modify the behavior of `--ini`.
@TimWolla TimWolla requested review from bukka and Girgias February 11, 2025 12:01
Girgias
Girgias reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure how opt parsing works TBH. If Jakub doesn't review soonish I'll go and dig into the code to properly understand it.

@cmb69
Copy link
Member

cmb69 commented Feb 17, 2025

Looks good to me. (An alternative might be to add --ini-diff.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

@bukka bukka Awaiting requested review from bukka

Assignees
No one assigned
Labels
ABI break SAPI: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @cmb69 @Girgias